Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove RESULT_SCAN dep. #13904

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix: remove RESULT_SCAN dep. #13904

merged 1 commit into from
Nov 9, 2023

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Nov 8, 2023

Describe your changes:

  • result_scan will only return the info for a query ran by the users, we need to get the info directly from the query_history

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@TeddyCr TeddyCr requested a review from a team as a code owner November 8, 2023 16:24
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Nov 8, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 8, 2023

[open-metadata-ingestion] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

19.4% 19.4% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@TeddyCr TeddyCr merged commit 7f151ca into open-metadata:main Nov 9, 2023
14 of 18 checks passed
TeddyCr added a commit that referenced this pull request Nov 10, 2023
@TeddyCr
fix: remove RESULT_SCAN dep. (#13904)
7ef3e7a 
(cherry picked from commit 7f151ca)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

@harshach harshach harshach approved these changes

Assignees
No one assigned
Labels
Ingestion profiler safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TeddyCr @harshach @pmbrull