Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Migration Extension Path Env #13908

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Remove Migration Extension Path Env #13908

merged 1 commit into from
Nov 9, 2023

Conversation

mohityadav766
Copy link
Contributor

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mohityadav766 mohityadav766 self-assigned this Nov 9, 2023
@mohityadav766 mohityadav766 requested review from harshach and a team as code owners November 9, 2023 08:33
@github-actions github-actions bot added backend devops safe to test Add this label to run secure Github workflows on PRs labels Nov 9, 2023
@mohityadav766 mohityadav766 merged commit bd6e296 into main Nov 9, 2023
14 checks passed
@mohityadav766 mohityadav766 deleted the removeEnvForMigrationPath branch November 9, 2023 08:34
mohityadav766 added a commit that referenced this pull request Nov 9, 2023
@mohityadav766
Remove Migration Extension Path Env (#13908)
4b57789 
(cherry picked from commit bd6e296)
akash-jain-10
akash-jain-10 reviewed Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@akash-jain-10 akash-jain-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 9, 2023

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

chirag-madlani pushed a commit that referenced this pull request Nov 10, 2023
@mohityadav766 @chirag-madlani
Remove Migration Extension Path Env (#13908)
96a4c9e 
(cherry picked from commit bd6e296)
(cherry picked from commit 4b57789)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akash-jain-10 akash-jain-10 akash-jain-10 left review comments

@harshach harshach Awaiting requested review from harshach harshach is a code owner

Assignees

@mohityadav766 mohityadav766

Labels
backend devops safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohityadav766 @akash-jain-10