Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): supported to see all personas in the user profile dropdown #13915

Merged
merged 3 commits into from
Nov 9, 2023
Merged

fix(ui): supported to see all personas in the user profile dropdown #13915

merged 3 commits into from
Nov 9, 2023

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Nov 9, 2023 •
edited
Loading

Describe your changes:

Fixes : #13316 (comment))

  • I worked on supporting to see all personas in the user profile dropdown
  • minor code improvement
Screen.Recording.2023-11-09.at.4.30.32.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Nov 9, 2023
@Ashish8689 Ashish8689 self-assigned this Nov 9, 2023
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Nov 9, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 48.87% (23441/47967) 30.75% (8800/28621) 30.4% (2671/8786)

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 9, 2023

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Ashish8689 Ashish8689 merged commit 5f9f7ae into main Nov 9, 2023
14 checks passed
@Ashish8689 Ashish8689 deleted the persona-profile-more branch November 9, 2023 12:16
Ashish8689 added a commit that referenced this pull request Nov 9, 2023
@Ashish8689
fix(ui): supported to see all personas in the user profile dropdown (#…
dfd9db0 
…13915)

* supported to see all persona in user profile dropdown

* fix dropdown closing on more click for persona

* minor changes

(cherry picked from commit 5f9f7ae)
chirag-madlani pushed a commit that referenced this pull request Nov 10, 2023
@Ashish8689 @chirag-madlani
fix(ui): supported to see all personas in the user profile dropdown (#…
0e45b83 
…13915)

* supported to see all persona in user profile dropdown

* fix dropdown closing on more click for persona

* minor changes

(cherry picked from commit 5f9f7ae)
(cherry picked from commit dfd9db0)
ulixius9 pushed a commit that referenced this pull request Nov 10, 2023
@Ashish8689 @ulixius9
fix(ui): supported to see all personas in the user profile dropdown (#…
5e854d9 
…13915)

* supported to see all persona in user profile dropdown

* fix dropdown closing on more click for persona

* minor changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release 1.2 - UI Feedback
2 participants
@Ashish8689 @chirag-madlani