Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Data Insight Layout looks broken in case of large number of assets #13803 #13921

Merged
merged 4 commits into from
Nov 10, 2023
Merged

[UI] Data Insight Layout looks broken in case of large number of assets #13803 #13921

merged 4 commits into from
Nov 10, 2023

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Nov 9, 2023 •
edited
Loading

Describe your changes:

Fixes #13803

  • Fixed Broken UI when there is large number of services in Data insight graph
  • Updated new UI and refactored the code .
Screen.Recording.2023-11-09.at.8.54.10.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Nov 9, 2023
@ShaileshParmar11 ShaileshParmar11 self-assigned this Nov 9, 2023
chirag-madlani
chirag-madlani previously approved these changes Nov 10, 2023
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 48.93% (23585/48205) 30.76% (8897/28928) 30.49% (2694/8837)

@sonarqubecloud SonarQubeCloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
27.2% 27.2% Duplication

@ShaileshParmar11 ShaileshParmar11 merged commit cefe222 into main Nov 10, 2023
14 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the issue-13803 branch November 10, 2023 08:23
ShaileshParmar11 added a commit that referenced this pull request Nov 10, 2023
@ShaileshParmar11
[UI] Data Insight Layout looks broken in case of large number of assets
e86b578 
#13803 (#13921)

* [UI] Data Insight Layout looks broken in case of large number of assets #13803

* move height to constant variable in cost file

* fixed DI cypress

* fixed failing unit test
ulixius9 pushed a commit that referenced this pull request Nov 10, 2023
@ShaileshParmar11 @ulixius9
[UI] Data Insight Layout looks broken in case of large number of assets
54958ca 
#13803 (#13921)

* [UI] Data Insight Layout looks broken in case of large number of assets #13803

* move height to constant variable in cost file

* fixed DI cypress

* fixed failing unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@ShaileshParmar11 ShaileshParmar11

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Data Insight Layout looks broken in case of large number of assets
2 participants
@ShaileshParmar11 @chirag-madlani