Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #13699 - Add separator for Storage Container manifest #13924

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Fix #13699 - Add separator for Storage Container manifest #13924

merged 4 commits into from
Nov 10, 2023

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Nov 9, 2023

Describe your changes:

Fix #13699

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@pmbrull pmbrull requested a review from a team as a code owner November 9, 2023 15:50
@github-actions github-actions bot added documentation Improvements or additions to documentation Ingestion backend labels Nov 9, 2023
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Nov 9, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 9, 2023

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@pmbrull pmbrull merged commit b250cd8 into open-metadata:main Nov 10, 2023
18 checks passed
@pmbrull pmbrull deleted the issue-13699 branch November 10, 2023 09:45
pmbrull added a commit that referenced this pull request Nov 10, 2023
@pmbrull
Fix #13699 - Add separator for Storage Container manifest (#13924)
d4f25d2 
* Fix #13699 - Add separator for Storage Container manifest

* Fix #13906 - Fix add_mlmodel_lineage description field

* Add separator

* Add separator
ulixius9 pushed a commit that referenced this pull request Nov 10, 2023
@pmbrull @ulixius9
Fix #13699 - Add separator for Storage Container manifest (#13924)
8c6ba93 
* Fix #13699 - Add separator for Storage Container manifest

* Fix #13906 - Fix add_mlmodel_lineage description field

* Add separator

* Add separator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeddyCr TeddyCr TeddyCr approved these changes

Assignees
No one assigned
Labels
backend documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow user to specify .csv separator in storage manifest file
2 participants
@pmbrull @TeddyCr