Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use displayName instead of name in service,database, databaseSchema and fixed owner and domain search issue. #13937

Merged
merged 7 commits into from
Nov 13, 2023
Merged

use displayName instead of name in service,database, databaseSchema and fixed owner and domain search issue. #13937

merged 7 commits into from
Nov 13, 2023

Conversation

07Himank
Copy link
Contributor

Fixes : #13874

I worked on ... because ... use displayName instead of name in service,database, databaseSchema and fixed owner and domain search issue.

Type of change:

  • [ x] Bug fix
  • [x ] Improvement

@07Himank 07Himank added the safe to test Add this label to run secure Github workflows on PRs label Nov 10, 2023
@github-actions github-actions bot added UI UI specific issues backend labels Nov 10, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 10, 2023 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 48.81% (23645/48439) 30.43% (8851/29086) 30.27% (2679/8850)

@sonarqubecloud SonarQubeCloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mohityadav766 mohityadav766 merged commit 759bd84 into main Nov 13, 2023
16 of 17 checks passed
@mohityadav766 mohityadav766 deleted the displayNameFix branch November 13, 2023 08:02
mohityadav766 pushed a commit that referenced this pull request Nov 13, 2023
@07Himank @mohityadav766
use displayName instead of name in service,database, databaseSchema a…
cc1bc47 
…nd fixed owner and domain search issue. (#13937)

* use displayName instead of name in service,database, databaseSchema and fixed owner and domain search issue

* typo fix

* improve code reusabilty

(cherry picked from commit 759bd84)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohityadav766 mohityadav766 mohityadav766 approved these changes

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees
No one assigned
Labels
backend safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backend: ElasticSearch is not getting updated after removing domain
3 participants
@07Himank @chirag-madlani @mohityadav766