Paging improvement #13943
Merged
Paging improvement #13943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
UI
Jest test CoverageUI tests summary
|
karanh37
approved these changes
Nov 10, 2023
|
[open-metadata-ui] Kudos, SonarCloud Quality Gate passed! |
mgorsk1
reviewed
Nov 10, 2023
| showPagination, | ||
| } = usePaging(); | ||
|
|
||
| const fetchDatabaseSchema = useCallback( |
There was a problem hiding this comment.
wouldn't it simplify this component if fetchDatabaseSchema and searchSchema are replaced by single function that uses same query but query_text is:
*when search box is empty and(name.keyword:*${searchValue}*) OR (description.keyword:*${searchValue}*)when search box is not empty
it would:
- centralize the way data is fetched (and from where it's fetched) and follow DRY approach
- keep just one logic of pagination
chirag-madlani
added a commit
that referenced
this pull request
Nov 10, 2023
* fix(ui): databaseschema paging issue * fix minor issues * test fixes * fix path issue and some cypress * fix sonarcloud (cherry picked from commit e2418ae)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes #13925
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>