Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): delete widget modal bug #13945

Merged
merged 1 commit into from
Nov 10, 2023
Merged

fix(ui): delete widget modal bug #13945

merged 1 commit into from
Nov 10, 2023

Conversation

aniketkatkar97
Copy link
Member

I worked on fixing the issue for the Delete widget modal, where the delete state was being reset to the wrong value.

Before:

Screen.Recording.2023-11-10.at.10.11.12.PM.mov

After:

Screen.Recording.2023-11-10.at.10.11.35.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@aniketkatkar97 aniketkatkar97 added the UI UI specific issues label Nov 10, 2023
@aniketkatkar97 aniketkatkar97 requested a review from a team November 10, 2023 16:44
@aniketkatkar97 aniketkatkar97 self-assigned this Nov 10, 2023
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Nov 10, 2023
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 48.94% (23679/48383) 30.46% (8857/29077) 30.34% (2684/8846)

@sonarqubecloud SonarQubeCloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@aniketkatkar97 aniketkatkar97 merged commit 1e3d7f8 into main Nov 10, 2023
17 of 18 checks passed
@aniketkatkar97 aniketkatkar97 deleted the fix-delete-widget-bug branch November 10, 2023 18:21
aniketkatkar97 added a commit that referenced this pull request Nov 10, 2023
@aniketkatkar97
Fixed bug on delete widget modal (#13945)
c641432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@aniketkatkar97 aniketkatkar97

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aniketkatkar97 @chirag-madlani @ShaileshParmar11