Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Resource - Add /configure endpoint & WAII app definition #13983

Merged
merged 7 commits into from
Nov 17, 2023
Merged

App Resource - Add /configure endpoint & WAII app definition #13983

merged 7 commits into from
Nov 17, 2023

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Nov 15, 2023 •
edited
Loading

Describe your changes:

  1. Add the /configure endpoint for Apps
  2. Inform the openMetadataServerConnection in Apps when we schedule/configure them, since this is needed by the MetaPilot App to have the OM server info.
  3. App config definition for the MetaPilot

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added backend Ingestion safe to test Add this label to run secure Github workflows on PRs labels Nov 15, 2023
@pmbrull pmbrull marked this pull request as ready for review November 17, 2023 07:16
@pmbrull pmbrull requested review from a team as code owners November 17, 2023 07:17
@sonarqubecloud SonarQubeCloud
Copy link

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pmbrull pmbrull merged commit 6fb3f12 into open-metadata:main Nov 17, 2023
@pmbrull pmbrull deleted the app-configure branch November 17, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohityadav766 mohityadav766 mohityadav766 approved these changes

Assignees
No one assigned
Labels
backend Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmbrull @mohityadav766