Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): updated github popup card #13996

Merged
merged 3 commits into from
Nov 16, 2023
Merged

fix(ui): updated github popup card #13996

merged 3 commits into from
Nov 16, 2023

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Nov 16, 2023 •
edited
Loading

Describe your changes:

  • I worked on updating github popup description
  • added cancelable option
image
Screen.Recording.2023-11-16.at.8.52.35.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Nov 16, 2023
@Ashish8689 Ashish8689 self-assigned this Nov 16, 2023
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Nov 16, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 16, 2023 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 48.81% (23647/48447) 30.44% (8860/29102) 30.27% (2679/8849)

@Ashish8689 Ashish8689 changed the title fix(ui): updated github popup description fix(ui): updated github popup card Nov 16, 2023
@sonarqubecloud SonarQubeCloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ShaileshParmar11 ShaileshParmar11 merged commit 5ae43f0 into main Nov 16, 2023
15 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the github-popup-description branch November 16, 2023 16:22
ShaileshParmar11 pushed a commit that referenced this pull request Nov 16, 2023
@Ashish8689 @ShaileshParmar11
fix(ui): updated github popup card (#13996)
0aabfc0 
* updated github popup description

* added cancel button

* minor changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@harshach harshach harshach approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ashish8689 @harshach @ShaileshParmar11