Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: 14240 and Fixes 13365: Bulk patch descriptions from dbt #13999

Merged
merged 6 commits into from
Dec 6, 2023
Merged

Fixes: 14240 and Fixes 13365: Bulk patch descriptions from dbt #13999

merged 6 commits into from
Dec 6, 2023

Conversation

OnkarVO7
Copy link
Contributor

@OnkarVO7 OnkarVO7 commented Nov 16, 2023 •
edited
Loading

Describe your changes:

Fixes #13365
Fixes #14240
Minor fixes for sourceHash when descriptions are patched from dbt

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Nov 16, 2023
@OnkarVO7 OnkarVO7 changed the title Bulk patch descriptions and tags from Ingestion Fixes 14240 and MINOR: Bulk patch descriptions from dbt Dec 6, 2023
@OnkarVO7 OnkarVO7 changed the title Fixes 14240 and MINOR: Bulk patch descriptions from dbt Fixes: 14240 and MINOR: Bulk patch descriptions from dbt Dec 6, 2023
@OnkarVO7 OnkarVO7 changed the title Fixes: 14240 and MINOR: Bulk patch descriptions from dbt Fixes: 14240 and Fixes 13365: Bulk patch descriptions from dbt Dec 6, 2023
@OnkarVO7 OnkarVO7 marked this pull request as ready for review December 6, 2023 10:56
@OnkarVO7 OnkarVO7 requested review from a team as code owners December 6, 2023 10:56
07Himank
07Himank previously approved these changes Dec 6, 2023
View reviewed changes
@OnkarVO7 OnkarVO7 requested review from ulixius9 and 07Himank December 6, 2023 11:57
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2023

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

76.3% 76.3% Coverage
0.0% 0.0% Duplication

@ulixius9 ulixius9 merged commit c7e32c8 into main Dec 6, 2023
@ulixius9 ulixius9 deleted the bulk_patch branch December 6, 2023 13:30
OnkarVO7 added a commit that referenced this pull request Dec 6, 2023
@OnkarVO7
Fixes: 14240 and Fixes 13365: Bulk patch descriptions from dbt (#13999)
64e01b3
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this pull request Dec 15, 2023
@OnkarVO7
Fixes: 14240 and Fixes 13365: Bulk patch descriptions from dbt (open-…
cef0a4f 
…metadata#13999)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulixius9 ulixius9 ulixius9 approved these changes

@07Himank 07Himank Awaiting requested review from 07Himank

Assignees
No one assigned
Labels
backend Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DBT 1.6 version cause breaking changes on the current dbt source ingestion config Use PATCH API in bulk
3 participants
@OnkarVO7 @ulixius9 @07Himank