Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui & backend: explore page count was not showing properly #14013

Merged
merged 4 commits into from
Nov 17, 2023
Merged

ui & backend: explore page count was not showing properly #14013

merged 4 commits into from
Nov 17, 2023

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Nov 17, 2023 •
edited
Loading

resolve count issue from backend and added data product in global search dropdown from UI

Screen.Recording.2023-11-17.at.8.18.53.PM.mov
Screen.Recording.2023-11-17.at.8.21.23.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Nov 17, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 17, 2023 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 48.8% (23647/48456) 30.45% (8860/29099) 30.27% (2679/8849)

@ShaileshParmar11 ShaileshParmar11 changed the title explore page count was not showing properly ui & backend: explore page count was not showing properly Nov 17, 2023
@ShaileshParmar11 ShaileshParmar11 marked this pull request as ready for review November 17, 2023 14:32
@sonarqubecloud SonarQubeCloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud SonarQubeCloud
Copy link

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chirag-madlani chirag-madlani merged commit efb6c5f into main Nov 17, 2023
21 of 27 checks passed
@chirag-madlani chirag-madlani deleted the explore-count-issue branch November 17, 2023 16:19
ShaileshParmar11 added a commit that referenced this pull request Nov 17, 2023
@ShaileshParmar11
ui & backend: explore page count was not showing properly (#14013)
e34d4cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohityadav766 mohityadav766 mohityadav766 approved these changes

@Ashish8689 Ashish8689 Ashish8689 approved these changes

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach harshach approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees
No one assigned
Labels
backend safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ShaileshParmar11 @harshach @chirag-madlani @Ashish8689 @mohityadav766 @07Himank