Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake SP don't filter by warehouse #14018

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Nov 17, 2023

Describe your changes:

Since the service can live in one warehouse and the queries are executed in another

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@pmbrull pmbrull requested a review from a team as a code owner November 17, 2023 12:01
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Nov 17, 2023
Copy link

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pmbrull pmbrull merged commit a8a1fd2 into open-metadata:main Nov 17, 2023
12 checks passed
@pmbrull pmbrull deleted the snowflake-no-wh-filter branch November 17, 2023 13:18
pmbrull added a commit that referenced this pull request Nov 17, 2023
pmbrull added a commit that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants