Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): #13963 glossary term custom property update #14035

Merged
merged 1 commit into from
Nov 20, 2023
Merged

fix(ui): #13963 glossary term custom property update #14035

merged 1 commit into from
Nov 20, 2023

Conversation

chirag-madlani
Copy link
Collaborator

@chirag-madlani chirag-madlani commented Nov 20, 2023 •
edited
Loading

Describe your changes:

Fixes: #13963

I worked on the fix glossary term not updating Custom properties

Screen.Recording.2023-11-20.at.4.03.48.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Nov 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 48.8% (23649/48458) 30.45% (8860/29099) 30.27% (2679/8849)

@sonarqubecloud SonarQubeCloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@chirag-madlani chirag-madlani merged commit 079f78c into main Nov 20, 2023
15 checks passed
@chirag-madlani chirag-madlani deleted the fix-#13963 branch November 20, 2023 14:55
chirag-madlani added a commit that referenced this pull request Dec 1, 2023
@chirag-madlani
fix(ui): #13963 glossary term custom property update (#14035)
a5d7740 
(cherry picked from commit 079f78c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karanh37 karanh37 karanh37 approved these changes

@harshach harshach Awaiting requested review from harshach

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom Properties don't accept any values
2 participants
@chirag-madlani @karanh37