Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11357 - DB migration for custom metrics #14036

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Nov 20, 2023

Describe your changes:

Fixes #11357

  • rename profile metric key to customMetrics
  • Delete customMetrics for extension. Implementation has been overhauled and OM has not had support for computing custom metrics since now. As a result we are deleting the existing data if any were ingested from via the API. Users we'll need to recreate it if there were some customMetrics definition

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • I have added tests around the new logic.
  • For connector/ingestion changes: I updated the documentation.

@TeddyCr TeddyCr requested a review from a team November 20, 2023 11:22
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Nov 20, 2023
@pmbrull pmbrull merged commit cabc346 into open-metadata:main Nov 23, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backward-Incompatible-Change Ingestion profiler safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Processing of Custom Profiler Metrics
3 participants