Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add RTL support in description editor #14057

Merged
merged 1 commit into from
Nov 22, 2023
Merged

feat(ui): add RTL support in description editor #14057

merged 1 commit into from
Nov 22, 2023

Conversation

Sachin-chaurasiya
Copy link
Member

Describe your changes:

Part of #14047

I worked on adding RTL support in the description editor.

Screen.Recording.2023-11-21.at.7.22.07.PM.mov

Type of change:

  • New feature

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Nov 21, 2023
@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Nov 21, 2023
@Sachin-chaurasiya Sachin-chaurasiya marked this pull request as ready for review November 21, 2023 14:04
@Sachin-chaurasiya Sachin-chaurasiya mentioned this pull request Nov 21, 2023
Closed
6 tasks
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 48.68% (23666/48618) 30.39% (8861/29153) 30.2% (2681/8877)

@sonarqubecloud SonarQubeCloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@chirag-madlani chirag-madlani merged commit e97559b into main Nov 22, 2023
14 checks passed
@chirag-madlani chirag-madlani deleted the issue-14047-description-editor branch November 22, 2023 09:21
Sachin-chaurasiya added a commit that referenced this pull request Nov 23, 2023
@Sachin-chaurasiya
feat(ui): add RTL support in description editor (#14057)
9078228 
(cherry picked from commit e97559b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@Sachin-chaurasiya Sachin-chaurasiya

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sachin-chaurasiya @chirag-madlani