Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): column name overlapping in entity table #14086

Merged
merged 3 commits into from
Nov 24, 2023
Merged

fix(ui): column name overlapping in entity table #14086

merged 3 commits into from
Nov 24, 2023

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

Fixes #14003

  • I worked on fixing the column name overlapping issue in entity tables
image image image image image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Nov 23, 2023
@Ashish8689 Ashish8689 self-assigned this Nov 23, 2023
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Nov 23, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 23, 2023 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 48.65% (23682/48678) 30.42% (8879/29189) 30.17% (2681/8886)

@sonarqubecloud SonarQubeCloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Ashish8689 Ashish8689 merged commit 1540329 into main Nov 24, 2023
@Ashish8689 Ashish8689 deleted the column-name-overlaping branch November 24, 2023 06:45
Ashish8689 added a commit that referenced this pull request Nov 25, 2023
@Ashish8689
fix(ui): column name overlapping in entity table (#14086)
be07bd4 
* fix column name overlaping in entity table

* minor fixes

(cherry picked from commit 1540329)
Ashish8689 added a commit that referenced this pull request Nov 28, 2023
@Ashish8689
fix(ui): column name overlapping in entity table (#14086)
71449eb 
* fix column name overlaping in entity table

* minor fixes

(cherry picked from commit 1540329)
(cherry picked from commit be07bd4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OM-1.2.0 - Long column names are breaking the UI
2 participants
@Ashish8689 @chirag-madlani