Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pipeline task filtering for failed status #14093

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Fix pipeline task filtering for failed status #14093

merged 3 commits into from
Nov 24, 2023

Conversation

dechoma
Copy link
Contributor

@dechoma dechoma commented Nov 23, 2023 •
edited
Loading

Describe your changes:

Fixes #14092

a naive approach to fix a bug described in #14092

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added the UI UI specific issues label Nov 23, 2023
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@harshach harshach added the safe to test Add this label to run secure Github workflows on PRs label Nov 23, 2023
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 48.65% (23682/48679) 30.41% (8877/29187) 30.17% (2681/8887)

@sonarqubecloud SonarQubeCloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chirag-madlani chirag-madlani merged commit f95867a into open-metadata:main Nov 24, 2023
14 checks passed
Ashish8689 pushed a commit that referenced this pull request Nov 28, 2023
@dechoma @Ashish8689
Fix pipeline task filtering for failed status (#14093)
70e3782 
* fix task status failed name

* Table's rowKey should be unique

(cherry picked from commit f95867a)
@dechoma dechoma deleted the fix/task_statuses branch June 11, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@chirag-madlani chirag-madlani

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui: Task filter in pipeline execution component does not work for Failed tasks
3 participants
@dechoma @chirag-madlani @harshach