Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): unwanted scrollbar in explore page #14097

Merged
merged 1 commit into from
Nov 24, 2023
Merged

fix(ui): unwanted scrollbar in explore page #14097

merged 1 commit into from
Nov 24, 2023

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Nov 24, 2023 •
edited
Loading

Describe your changes:

Fixes #13806

  • unwanted scrollbar in explore page
  • scrolling issue in the summary panel
  • encoding issue in database detail and schema page

Issue :

image image

Resolved :
image

image image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Nov 24, 2023
@Ashish8689 Ashish8689 self-assigned this Nov 24, 2023
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Nov 24, 2023
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 48.65% (23682/48683) 30.41% (8877/29187) 30.16% (2681/8888)

@sonarqubecloud SonarQubeCloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@chirag-madlani chirag-madlani merged commit 59b048a into main Nov 24, 2023
18 checks passed
@chirag-madlani chirag-madlani deleted the explore-scrollbar branch November 24, 2023 13:40
Ashish8689 added a commit that referenced this pull request Nov 25, 2023
@Ashish8689
fix unwanted scrollbar in explore page (#14097)
9c7c6ad 
(cherry picked from commit 59b048a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
2 participants
@Ashish8689 @chirag-madlani