Feat: #11346 Add UI Support to Add Custom Profiler Metrics #14132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
UI
Jest test CoverageUI tests summary
|
|
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
- Add - Edit - Delete table and column custom metric
- NoProfilerBanner - CustomMetricGraphs
ShaileshParmar11
changed the title
ShaileshParmar11
had a problem deploying
to
test
GitHub Actions
Failure
ShaileshParmar11
had a problem deploying
to
test
GitHub Actions
Failure
ShaileshParmar11
requested review from
harshach,
karanh37 and
chirag-madlani
as code owners
chirag-madlani
requested changes
Dec 8, 2023
| const addButtonContent = [ | ||
| { | ||
| label: <TabsLabel id="test-case" name={t('label.test-case')} />, | ||
| key: '1', |
There was a problem hiding this comment.
Suggested change
| key: '1', | |
| key: 'test-case', |
| }, | ||
| { | ||
| label: <TabsLabel id="metric" name={t('label.custom-metric')} />, | ||
| key: '2', |
There was a problem hiding this comment.
Suggested change
| key: '2', | |
| key: 'custom-metric', |
...ta-ui/src/main/resources/ui/src/components/TableProfiler/QualityTab/QualityTab.component.tsx
Show resolved
Hide resolved
Comment on lines
102
to
128
| const testCaseTypeOption = useMemo(() => { | ||
| const testCaseStatus: DefaultOptionType[] = map(TestType, (value, key) => ({ | ||
| label: key, | ||
| value: value, | ||
| })); | ||
| testCaseStatus.unshift({ | ||
| label: t('label.all'), | ||
| value: '', | ||
| }); | ||
|
|
||
| return testCaseStatus; | ||
| }, []); | ||
|
|
||
| const testCaseStatusOption = useMemo(() => { | ||
| const testCaseStatus: DefaultOptionType[] = Object.values( | ||
| TestCaseStatus | ||
| ).map((value) => ({ | ||
| label: value, | ||
| value: value, | ||
| })); | ||
| testCaseStatus.unshift({ | ||
| label: t('label.all'), | ||
| value: '', | ||
| }); | ||
|
|
||
| return testCaseStatus; | ||
| }, []); |
There was a problem hiding this comment.
We can have this things as const to execute it only once and use it across
| ); | ||
|
|
||
| return searchData as { activeTab: string; activeColumnFqn: string }; | ||
| }, [location.search, isTourOpen]); |
There was a problem hiding this comment.
Please import location from useLocation
Comment on lines
50
to
52
| export const TableProfilerContext = createContext<TableProfilerContextType>( | ||
| {} as TableProfilerContextType | ||
| ); |
| ); | ||
|
|
||
| return searchData as { activeTab: string; activeColumnFqn: string }; | ||
| }, [location.search, isTourOpen]); |
There was a problem hiding this comment.
import location from useLocation
Comment on lines
88
to
90
| const isColumnProfile = activeTab === TableProfilerTab.COLUMN_PROFILE; | ||
| const isDataQuality = activeTab === TableProfilerTab.DATA_QUALITY; | ||
| const isTableProfile = activeTab === TableProfilerTab.TABLE_PROFILE; |
| // As we are encoding the fqn in API function to apply all over the application | ||
| // and the datasetFQN comes form url parameter which is already encoded, | ||
| // we are decoding FQN below to avoid double encoding in the API function | ||
| const decodedDatasetFQN = decodeURIComponent(datasetFQN); |
There was a problem hiding this comment.
Suggested change
| const decodedDatasetFQN = decodeURIComponent(datasetFQN); | |
| const decodedDatasetFQN = getDecodedFQN(datasetFQN); |
| @@ -63,6 +63,8 @@ const DeleteWidgetModal = ({ | |||
| afterDeleteAction, | |||
| successMessage, | |||
| deleteOptions, | |||
| onDelete, | |||
| loading = false, | |||
There was a problem hiding this comment.
Why loading for Modal
There was a problem hiding this comment.
it's for the submit button, as we are also providing an option for onDelete, we also need to provide a loading option for that.
|
[open-metadata-ui] Kudos, SonarCloud Quality Gate passed! |
chirag-madlani
approved these changes
Dec 11, 2023
Comment on lines
+231
to
+248
| const fetchProfiler = | ||
| !isTableDeleted && | ||
| datasetFQN && | ||
| !isTourOpen && | ||
| [ | ||
| TableProfilerTab.TABLE_PROFILE, | ||
| TableProfilerTab.COLUMN_PROFILE, | ||
| ].includes(activeTab) && | ||
| isUndefined(tableProfiler); | ||
|
|
||
| if (fetchProfiler) { | ||
| fetchLatestProfilerData(); | ||
| } else { | ||
| setIsProfilerDataLoading(false); | ||
| } | ||
| if (isTourOpen) { | ||
| setTableProfiler(mockDatasetData.tableDetails as unknown as Table); | ||
| } |
There was a problem hiding this comment.
Can we simplify this conditions?
Comment on lines
+252
to
+264
| const fetchTest = | ||
| viewTest && | ||
| !isTourOpen && | ||
| [TableProfilerTab.DATA_QUALITY, TableProfilerTab.COLUMN_PROFILE].includes( | ||
| activeTab | ||
| ) && | ||
| isEmpty(allTestCases); | ||
|
|
||
| if (fetchTest) { | ||
| fetchAllTests(); | ||
| } else { | ||
| setIsTestsLoading(false); | ||
| } |
MrVinegar
pushed a commit
to MrVinegar/OpenMetadata
that referenced
this pull request
Dec 15, 2023
…cs (open-metadata#14132) * open-metadata#11346 Add UI Support to Add Custom Profiler Metrics * fixed failing unit test * fixed loading issue and added no profiler banner in column profile component * create context provider and removed all the common props to context * fixed failing unit test * miner fixes * added view part of custom metrics * added: - Edit action - Delete action - Basic structure of add form * translation * work on create custom metric for table and column. * refactor structure in addCustomMetric page * fixed failing unit test * fixed failing cypress test and added create custom metric cypress test * added cypress test for custom metric covered below scenarios - Add - Edit - Delete table and column custom metric * added unit test for customMetricForm * added unit test for - NoProfilerBanner - CustomMetricGraphs * unit test for addCustomMetricPage * added unit test for utils file * fixed failing unit test * fixed encoding issue * addressing comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixs #11346
Screen.Recording.2023-12-05.at.6.06.58.PM.mov
Screen.Recording.2023-12-05.at.6.08.36.PM.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>