Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#14115: Separate Unity Catalog From Databricks #14138

Merged
merged 6 commits into from
Dec 4, 2023
Merged

#14115: Separate Unity Catalog From Databricks #14138

merged 6 commits into from
Dec 4, 2023

Conversation

ulixius9
Copy link
Member

@ulixius9 ulixius9 commented Nov 28, 2023 •
edited
Loading

Describe your changes:

fix #14115: Separate Unity Catalog From Databricks

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added documentation Improvements or additions to documentation UI UI specific issues Ingestion backend safe to test Add this label to run secure Github workflows on PRs labels Nov 28, 2023
@ulixius9 ulixius9 marked this pull request as draft November 28, 2023 07:46
@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2023 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 48.54% (23682/48785) 30.26% (8865/29299) 30.11% (2683/8911)

@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@ulixius9 ulixius9 marked this pull request as ready for review November 28, 2023 12:07
@sonarqubecloud SonarQubeCloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud SonarQubeCloud
Copy link

[open-metadata-ingestion] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

15.2% 15.2% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

ulixius9
ulixius9 commented Nov 28, 2023
View reviewed changes
.../main/resources/json/schema/entity/services/connections/database/unityCatalogConnection.json
"$ref": "../connectionBasicType.json#/definitions/sampleDataStorageConfig"
}
},
"additionalProperties": false,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Have removed the supportProfiler from unity catalog connector as we have this ticket open #12947

@ulixius9 ulixius9 merged commit 389ae79 into main Dec 4, 2023
@ulixius9 ulixius9 deleted the issue-14115 branch December 4, 2023 05:52
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this pull request Dec 15, 2023
@ulixius9
open-metadata#14115: Separate Unity Catalog From Databricks (open-met…
b3bd074 
…adata#14138)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OnkarVO7 OnkarVO7 OnkarVO7 approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

Assignees
No one assigned
Labels
backend documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate Databricks & Unity Catalog Connectors
2 participants
@ulixius9 @OnkarVO7