Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui): install node-gyp as ui install step #14142

Merged
merged 3 commits into from
Nov 28, 2023
Merged

chore(ui): install node-gyp as ui install step #14142

merged 3 commits into from
Nov 28, 2023

Conversation

chirag-madlani
Copy link
Collaborator

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues devops safe to test Add this label to run secure Github workflows on PRs labels Nov 28, 2023
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 48.55% (23681/48780) 30.26% (8865/29297) 30.11% (2683/8911)

@sonarqubecloud SonarQubeCloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chirag-madlani chirag-madlani merged commit e2043a3 into main Nov 28, 2023
11 of 13 checks passed
@chirag-madlani chirag-madlani deleted the node-gyp branch November 28, 2023 10:34
Sachin-chaurasiya pushed a commit that referenced this pull request Dec 6, 2023
@chirag-madlani @Sachin-chaurasiya
chore(ui): install node-gyp as ui install step (#14142)
b5f27ff 
* chore(ui): install node-gyp as ui install step

* enable logs

* add pre-install for root

(cherry picked from commit e2043a3)
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this pull request Dec 15, 2023
@chirag-madlani
chore(ui): install node-gyp as ui install step (open-metadata#14142)
ed192e8 
* chore(ui): install node-gyp as ui install step

* enable logs

* add pre-install for root
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@karanh37 karanh37 karanh37 approved these changes

@akash-jain-10 akash-jain-10 akash-jain-10 approved these changes

@harshach harshach Awaiting requested review from harshach harshach is a code owner

Assignees
No one assigned
Labels
devops safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chirag-madlani @akash-jain-10 @karanh37 @Sachin-chaurasiya