Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs]- add ui doc for doris connector #14147

Merged
merged 4 commits into from
Dec 13, 2023
Merged

[Docs]- add ui doc for doris connector #14147

merged 4 commits into from
Dec 13, 2023

Conversation

chyueyi
Copy link
Contributor

@chyueyi chyueyi commented Nov 28, 2023

Describe your changes:

Doc #14144

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added the UI UI specific issues label Nov 28, 2023
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@chirag-madlani chirag-madlani added the safe to test Add this label to run secure Github workflows on PRs label Nov 28, 2023
@chyueyi chyueyi changed the title [DOCS]- add ui doc for doris connector [Docs]- add ui doc for doris connector Nov 28, 2023
ulixius9
ulixius9 previously approved these changes Nov 29, 2023
View reviewed changes
openmetadata-ui/src/main/resources/ui/public/locales/en-US/Database/Doris.md

## Requirements

You can find further information on the Doris connector in the [docs](https://docs.open-metadata.org/connectors/database/doris).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr @chyueyi, this link would currently not work as we have not added the docs in the docs dir, do you plan add the same with this pr? 🙇

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK @ulixius9

@ulixius9 ulixius9 dismissed their stale review November 29, 2023 12:37

waiting for response

@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 48.55% (23681/48780) 30.26% (8865/29297) 30.11% (2683/8911)

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 12, 2023
@sonarqubecloud SonarQubeCloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chyueyi
Copy link
Contributor Author

chyueyi commented Dec 13, 2023

Please review this pr @ulixius9

ulixius9
ulixius9 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@ulixius9 ulixius9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chyueyi

@ulixius9 ulixius9 merged commit bfe64e0 into open-metadata:main Dec 13, 2023
18 checks passed
@chyueyi chyueyi deleted the issue-14144 branch December 14, 2023 01:53
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this pull request Dec 15, 2023
@chyueyi
[Docs]- add ui doc for doris connector (open-metadata#14147)
47a00c2
@ShilpaVernekar
Copy link
Contributor

Hi @chyueyi
Hope you are doing well.
Please can we connect on OpenMetadata Slack to discuss further about your code contribution for Doris connector. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulixius9 ulixius9 ulixius9 approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chyueyi @ShilpaVernekar @ulixius9 @chirag-madlani