Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: fixes ingestion of sample data for custom metrics #14170

Merged
merged 4 commits into from
Nov 29, 2023
Merged

MINOR: fixes ingestion of sample data for custom metrics #14170

merged 4 commits into from
Nov 29, 2023

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Nov 29, 2023

Describe your changes:

  • added PUT request to ingest sample custom metrics definition
  • fix linitng for Doris connector

@TeddyCr TeddyCr requested a review from a team as a code owner November 29, 2023 10:59
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Nov 29, 2023
@github-actions GitHub Actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@TeddyCr TeddyCr requested a review from a team as a code owner November 29, 2023 11:02
@sonarqubecloud SonarQubeCloud
Copy link

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

40.0% 40.0% Coverage
0.0% 0.0% Duplication

@TeddyCr TeddyCr merged commit 8ff70e3 into open-metadata:main Nov 29, 2023
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this pull request Dec 15, 2023
@TeddyCr
MINOR: fixes ingestion of sample data for custom metrics (open-metada…
87b8242 
…ta#14170)

* fix: updated sample data ingestoon for custom metrics

* style: fix python linting

* style: fix java linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

Assignees
No one assigned
Labels
backend Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TeddyCr @pmbrull