Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #14165: fix Python SDK auth in 1.2.x doc #14172

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

gaborhermann
Copy link
Contributor

Describe your changes:

Fixes #14165

I worked on Python SDK docs because it didn't work out-of-the-box.

Type of change:

  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 29, 2023
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@gaborhermann
Copy link
Contributor Author

If you agree with the change, I can test the same on 1.0.x and 1.1.x and adjust the docs there too.

ayush-shah
ayush-shah previously approved these changes Nov 29, 2023
@ayush-shah
Copy link
Member

@gaborhermann can you add refer to optional attributes if the user wants to add like ssl or something else,
take a look at this: ingestion/src/metadata/generated/schema/entity/services/connections/metadata/openMetadataConnection.py

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@gaborhermann
Copy link
Contributor Author

@ayush-shah Sure, now I also added a note about other authentication methods.

I tested it with 1.0.5 server+client and could reproduce the same issue and same fix, so I also changed 1.0.x and 1.1.x docs the same way.

@ayush-shah
Copy link
Member

@gaborhermann Thanks for the contribution 🙌 , don't forget to hit the star in the project ⭐

@ayush-shah ayush-shah merged commit 5e55a3f into open-metadata:main Nov 30, 2023
8 of 10 checks passed
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python SDK guide local authentication does not work
2 participants