Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-14095: added overloaded method for method initClient to accept Feign.Builder as one of the method's parameter. #14175

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

FreeDevz
Copy link
Contributor

@FreeDevz FreeDevz commented Nov 29, 2023

Fixes #14095

  • What changes did you make?
    I added overloaded method for method initClient in org.openmetadata.client.gateway.OpenMetadata class to accept Feign.Builder as one of the method's parameter.
  • Why did you make them?
    To allow users to be able to configure the ApiClient, eg. set timeouts, add custom error handlers, use other Client besides OkHttpClient.
  • How did you test your changes?
    I made sure mvn compile passes on openmetadata-clients/openmetadata-java-client/pom.xml

…Feign.Builder as one of the method's parameter.
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@TeddyCr TeddyCr added the safe to test Add this label to run secure Github workflows on PRs label Nov 29, 2023
Copy link
Contributor

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@TeddyCr TeddyCr requested a review from a team November 30, 2023 10:22
@TeddyCr TeddyCr merged commit 5f88c8c into open-metadata:main Dec 4, 2023
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this pull request Dec 15, 2023
…Feign.Builder as one of the method's parameter. (open-metadata#14175)

Co-authored-by: Teddy <teddy.crepineau@gmail.com>
@vatisteve
Copy link

vatisteve commented Aug 16, 2024

Hi there, I've created a related issue for the enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenMetadata Java Client API caused application to hang when error occurred.
3 participants