FEAT Fix Issues in Glosary #14197
Merged
FEAT Fix Issues in Glosary #14197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohityadav766
added
the
safe to test
harshach
reviewed
Dec 1, 2023
harshach
reviewed
Dec 1, 2023
| }, | ||
| "default": null | ||
| }, | ||
| "assets": { |
There was a problem hiding this comment.
@mohityadav766 we need to figure out a way to force only few enttity types. Ie. adding of users/teams/roles/policies etc.. to the assets should be prohibited
* fix: assets fqn issue (#14140) * fix: assets fqn issue * fix: unit tests * fix: escape fqn in remaining areas * fix: domain cypress for adding assets * fix: add assets to data products cypress * update imports * add cypress for glossary term * fix: loading in asset modal and add cypress * fix: unit tests * fix: reintroduce filters in asset selection modal
Jest test CoverageUI tests summary
|
|
[open-metadata-ui] Kudos, SonarCloud Quality Gate passed! |
|
[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!
|
harshach
approved these changes
Dec 2, 2023
karanh37
added a commit
that referenced
this pull request
Dec 6, 2023
* Fix User Startup Email * Add Apis for validation and addtion glossary tags and assets * Update Status to ApiStatus * Unique Tags to be listed * Fix in tag additon * fix: asset selection modal improvements (#14152) * fix: assets fqn issue (#14140) * fix: assets fqn issue * fix: unit tests * fix: escape fqn in remaining areas * fix: domain cypress for adding assets * fix: add assets to data products cypress * update imports * add cypress for glossary term * fix: loading in asset modal and add cypress * fix: unit tests * fix: reintroduce filters in asset selection modal * fix: update assets * localization * Fixes and Refactor redundant code * Revert * Add Delete API for removing tags from assets * ADd ES calls * Fix Assests added in case of errors * ui updates * ui changes * Add Conditional Validate for SubFields --------- Co-authored-by: karanh37 <33024356+karanh37@users.noreply.github.com> Co-authored-by: karanh37 <karanh37@gmail.com>
MrVinegar
pushed a commit
to MrVinegar/OpenMetadata
that referenced
this pull request
Dec 15, 2023
* Fix User Startup Email * Add Apis for validation and addtion glossary tags and assets * Update Status to ApiStatus * Unique Tags to be listed * Fix in tag additon * fix: asset selection modal improvements (open-metadata#14152) * fix: assets fqn issue (open-metadata#14140) * fix: assets fqn issue * fix: unit tests * fix: escape fqn in remaining areas * fix: domain cypress for adding assets * fix: add assets to data products cypress * update imports * add cypress for glossary term * fix: loading in asset modal and add cypress * fix: unit tests * fix: reintroduce filters in asset selection modal * fix: update assets * localization * Fixes and Refactor redundant code * Revert * Add Delete API for removing tags from assets * ADd ES calls * Fix Assests added in case of errors * ui updates * ui changes * Add Conditional Validate for SubFields --------- Co-authored-by: karanh37 <33024356+karanh37@users.noreply.github.com> Co-authored-by: karanh37 <karanh37@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>