FIXES #14049 - Split test case resolution status from test case result #14204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeddyCr
requested review from
a team,
harshach,
karanh37 and
chirag-madlani
as code owners
github-actions
bot
added
UI
TeddyCr
changed the title
Jest test CoverageUI tests summary
|
|
cc @Ashish8689 |
harshach
reviewed
Dec 4, 2023
openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/TestCaseRepository.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/openmetadata/service/resources/dqtests/TestCaseResolutionStatusResource.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/openmetadata/service/resources/dqtests/TestCaseResolutionStatusResource.java
Show resolved
Hide resolved
...c/main/java/org/openmetadata/service/resources/dqtests/TestCaseResolutionStatusResource.java
Outdated
Show resolved
Hide resolved
...ice/src/main/java/org/openmetadata/service/search/indexes/TestCaseResolutionStatusIndex.java
Outdated
Show resolved
Hide resolved
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
|
[open-metadata-ui] Kudos, SonarCloud Quality Gate passed! |
|
[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed! |
harshach
approved these changes
Dec 5, 2023
MrVinegar
pushed a commit
to MrVinegar/OpenMetadata
that referenced
this pull request
Dec 15, 2023
…st case result (open-metadata#14204) * refactor: entityFQN as ListFilter condition * feat: implement resolution entity timeseries * fix: rename to testCaseResolutionStatus * ref: extracted ES query builder into private method * ref: extract OS query builder in its own method * ref: remove ingestion logic for test case resolution * fix: reorganize json schemas to fix circular import in Python * ref: object names in typescript code * feat: added indexing of test case resolution * feat: added test case resolution sample data * fix: test case resolution api logic * fix: audit logger for entityTimeSeriesInterface * fix: DDL generation * style: python linting * fix: skip UI test case resolution tests * fix: remove extension field * fix: renamed testCaseFailureStatus to testCaseResolutionStatus * fix: remove reviewer * fix: rename sequenceId to stateId * fix: re adjust search weights * fix: removed InReview status * style: ran python linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes #14049
Context
Test case resolution has been linked to the test case result itself. In this PR we split the test case resolution from the test case result into its own timeseries entity -- test case results keep a reference to an open test case resolution on failure.
IMPORTANT
The UI changed have been made to keep the UI functioning though this is a temporary change. Currently the test case resolution is not implemented from a UI point of view cc @ShaileshParmar11.
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Improvement
Backward-Incompatible-Change.