Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #13850: Glossary FQN should be used #14206

Merged
merged 3 commits into from
Dec 2, 2023
Merged

Fix #13850: Glossary FQN should be used #14206

merged 3 commits into from
Dec 2, 2023

Conversation

harshach
Copy link
Collaborator

@harshach harshach commented Dec 2, 2023 •
edited
Loading

Describe your changes:

Fixes #13850

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@harshach harshach requested a review from a team as a code owner December 2, 2023 02:38
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Dec 2, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 2, 2023

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@harshach harshach merged commit c9f3e3b into main Dec 2, 2023
14 checks passed
@harshach harshach deleted the issue-13850 branch December 2, 2023 19:12
harshach added a commit that referenced this pull request Dec 5, 2023
@harshach
Fix #13850: Glossary FQN should be used (#14206)
9815baa 
* Fix #13850: Glossary FQN should be used

* Minor: Initializing Glossary doesn't skip if it exists already
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this pull request Dec 15, 2023
@harshach
Fix open-metadata#13850: Glossary FQN should be used (open-metadata#1…
2558d15 
…4206)

* Fix open-metadata#13850: Glossary FQN should be used

* Minor: Initializing Glossary doesn't skip if it exists already
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terms don't show under Glossary with period character in name
1 participant
@harshach