Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#13912: Extend application schema files #14208

Merged
merged 7 commits into from
Dec 5, 2023
Merged

#13912: Extend application schema files #14208

merged 7 commits into from
Dec 5, 2023

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Dec 2, 2023 •
edited
Loading

Describe your changes:

fixes #13912

  • Extend application schema files

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Dec 2, 2023
@Ashish8689 Ashish8689 self-assigned this Dec 2, 2023
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Dec 2, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2023 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 49%
 49.32% (24242/49157) 31.7% (9366/29550) 30.57% (2746/8983)

ShaileshParmar11
ShaileshParmar11 reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from @chirag-madlani's comment, everything looks good.

@Ashish8689 Ashish8689 changed the title MINOR: Extend application schema files #13912: Extend application schema files Dec 5, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2023

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2023

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Ashish8689 Ashish8689 marked this pull request as ready for review December 5, 2023 13:55
@Ashish8689 Ashish8689 requested review from a team, harshach and karanh37 as code owners December 5, 2023 13:55
@chirag-madlani chirag-madlani merged commit 0fb0335 into main Dec 5, 2023
20 checks passed
@chirag-madlani chirag-madlani deleted the application-schema branch December 5, 2023 18:21
Ashish8689 added a commit that referenced this pull request Dec 6, 2023
@Ashish8689
#13912: Extend application schema files (#14208)
570fe1c 
* Extend application schema files

* minor changes

* properties change

(cherry picked from commit 0fb0335)
@harshach
Copy link
Collaborator

harshach commented Dec 6, 2023

@chirag-madlani @Ashish8689 do we need this for 1.2.3

@Ashish8689
Copy link
Contributor Author

@harshach yes, we need this to support cost analysis index.

@harshach
Copy link
Collaborator

harshach commented Dec 6, 2023

@Ashish8689 did we merge in?

@Ashish8689
Copy link
Contributor Author

yes, we have cherry-pick it 1.2.3

MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this pull request Dec 15, 2023
@Ashish8689
open-metadata#13912: Extend application schema files (open-metadata#1…
9ee634b 
…4208)

* Extend application schema files

* minor changes

* properties change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 left review comments

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya left review comments

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@Ashish8689 Ashish8689

Labels
backend safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support cost analysis re-index in Search indexing Application
5 participants
@Ashish8689 @harshach @chirag-madlani @Sachin-chaurasiya @ShaileshParmar11