Minor: add base class for tags #14218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sachin-chaurasiya
requested review from
harshach,
karanh37 and
chirag-madlani
as code owners
github-actions
bot
added
UI
chirag-madlani
previously approved these changes
Dec 4, 2023
Jest test CoverageUI tests summary
|
Sachin-chaurasiya
changed the title
chirag-madlani
approved these changes
Dec 4, 2023
|
[open-metadata-ui] Kudos, SonarCloud Quality Gate passed! |
Sachin-chaurasiya
added a commit
that referenced
this pull request
Dec 4, 2023
* Minor: exclude knowledge center classification tags from tag suggestion * add base class for tags * add unit test * clean up constants (cherry picked from commit 7ec6d77)
|
do we need this for 1.2.3? @Sachin-chaurasiya |
Yes, @harshach , it's cherry-picked to 1.2.3. |
MrVinegar
pushed a commit
to MrVinegar/OpenMetadata
that referenced
this pull request
Dec 15, 2023
* Minor: exclude knowledge center classification tags from tag suggestion * add base class for tags * add unit test * clean up constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
I worked on adding a base class for tags and using that class to fetch the tags.
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>