Minor: fixed KPI was showing success even the target was not met #14220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaileshParmar11
requested review from
harshach,
karanh37 and
chirag-madlani
as code owners
github-actions
bot
added
UI
ShaileshParmar11
changed the title
| className="w-full p-t-lg p-r-xs" | ||
| data-testid="kpi-latest-result-container" | ||
| direction="vertical" | ||
| size={48}> |
There was a problem hiding this comment.
Is this size intentional?
There was a problem hiding this comment.
Yes, it's intentional, to have a gap between 2 KPI
Jest test CoverageUI tests summary
|
|
[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!
|
chirag-madlani
approved these changes
Dec 4, 2023
ShaileshParmar11
added a commit
that referenced
this pull request
Dec 4, 2023
MrVinegar
pushed a commit
to MrVinegar/OpenMetadata
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
fixed KPI was showing success even the target was not met
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>