Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 14040: Part 2 Add Patch Request when updating the entities from create request #14224

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Fix 14040: Part 2 Add Patch Request when updating the entities from create request #14224

merged 5 commits into from
Dec 5, 2023

Conversation

OnkarVO7
Copy link
Contributor

@OnkarVO7 OnkarVO7 commented Dec 4, 2023

Describe your changes:

Add Patch Request when updating the entities from create request
Add sourceHash to entities and compare it while updating the entites

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@OnkarVO7 OnkarVO7 requested review from a team as code owners December 4, 2023 13:05
@github-actions github-actions bot added Ingestion backend safe to test Add this label to run secure Github workflows on PRs labels Dec 4, 2023
@OnkarVO7 OnkarVO7 marked this pull request as draft December 4, 2023 13:08
@OnkarVO7 OnkarVO7 marked this pull request as ready for review December 4, 2023 17:00
@OnkarVO7 OnkarVO7 requested review from harshach and a team December 5, 2023 05:50
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2023

[open-metadata-ingestion] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 1 Code Smell

64.6% 64.6% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ulixius9 ulixius9 merged commit b3578cd into main Dec 5, 2023
15 of 16 checks passed
@ulixius9 ulixius9 deleted the put_patch_changes branch December 5, 2023 12:26
OnkarVO7 added a commit that referenced this pull request Dec 5, 2023
@OnkarVO7
Fix 14040: Part 2 Add Patch Request when updating the entities from c…
2c6ef7d 
…reate request (#14224)
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this pull request Dec 15, 2023
@OnkarVO7
Fix 14040: Part 2 Add Patch Request when updating the entities from c…
f0aa4e4 
…reate request (open-metadata#14224)
@pmbrull pmbrull mentioned this pull request Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulixius9 ulixius9 ulixius9 approved these changes

@harshach harshach Awaiting requested review from harshach

Assignees
No one assigned
Labels
backend Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OnkarVO7 @harshach @ulixius9