Assets filters #14229
Merged
Assets filters #14229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
UI
Jest test CoverageUI tests summary
|
openmetadata-ui/src/main/resources/ui/src/components/AssetFilters/AssetFilters.component.tsx
Outdated
Show resolved
Hide resolved
openmetadata-ui/src/main/resources/ui/src/components/AssetFilters/AssetFilters.component.tsx
Outdated
Show resolved
Hide resolved
openmetadata-ui/src/main/resources/ui/src/components/AssetFilters/AssetFilters.interface.ts
Outdated
Show resolved
Hide resolved
...-ui/src/main/resources/ui/src/components/Assets/AssetsSelectionModal/AssetSelectionModal.tsx
Outdated
Show resolved
Hide resolved
...-ui/src/main/resources/ui/src/components/Assets/AssetsSelectionModal/AssetSelectionModal.tsx
Outdated
Show resolved
Hide resolved
...ui/src/components/DataProducts/DataProductsDetailsPage/DataProductsDetailsPage.component.tsx
Outdated
Show resolved
Hide resolved
...rc/main/resources/ui/src/components/Domain/DomainDetailsPage/DomainDetailsPage.component.tsx
Outdated
Show resolved
Hide resolved
...ui/src/main/resources/ui/src/components/Glossary/GlossaryTerms/tabs/AssetsTabs.component.tsx
Show resolved
Hide resolved
...ui/src/main/resources/ui/src/components/Glossary/GlossaryTerms/tabs/AssetsTabs.component.tsx
Outdated
Show resolved
Hide resolved
...ui/src/main/resources/ui/src/components/Glossary/GlossaryTerms/tabs/AssetsTabs.component.tsx
Outdated
Show resolved
Hide resolved
* fix(ui): throw validation errors while modifying glossary term * update modal layout
harshach
previously approved these changes
Dec 5, 2023
karanh37
commented
Dec 5, 2023
openmetadata-ui/src/main/resources/ui/src/components/Tag/TagsViewer/TagsViewer.tsx
Outdated
Show resolved
Hide resolved
openmetadata-ui/src/main/resources/ui/src/components/AsyncSelectList/AsyncSelectList.tsx
Outdated
Show resolved
Hide resolved
|
we have + sign below the search box Can we do the same in the adding assets |
chirag-madlani
approved these changes
Dec 5, 2023
Comment on lines
+274
to
+284
| const mergeFilters = useCallback(() => { | ||
| const res = getCombinedQueryFilterObject( | ||
| queryFilter as QueryFilterInterface, | ||
| quickFilterQuery as QueryFilterInterface | ||
| ); | ||
| setUpdatedQueryFilter(res); | ||
| }, [queryFilter, quickFilterQuery]); | ||
|
|
||
| useEffect(() => { | ||
| mergeFilters(); | ||
| }, [quickFilterQuery, queryFilter]); |
There was a problem hiding this comment.
we can replace it with single useMemo
|
[open-metadata-ui] Kudos, SonarCloud Quality Gate passed! |
karanh37
added a commit
that referenced
this pull request
Dec 6, 2023
* assets filter * localisation * update filters * fix: update filters on teams page * hide searchbar & restrict adding assets for draft * fix: code smells * fix: encoding decoding issues * fix: css * fix: add permissions check * fix(ui): throw validation errors while modifying glossary term (#14236) * fix(ui): throw validation errors while modifying glossary term * update modal layout * fix: domain cypress * minor update * update modal * fix: glossary cypress * fix: show inline errors * fix comments --------- Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
MrVinegar
pushed a commit
to MrVinegar/OpenMetadata
that referenced
this pull request
Dec 15, 2023
* assets filter * localisation * update filters * fix: update filters on teams page * hide searchbar & restrict adding assets for draft * fix: code smells * fix: encoding decoding issues * fix: css * fix: add permissions check * fix(ui): throw validation errors while modifying glossary term (open-metadata#14236) * fix(ui): throw validation errors while modifying glossary term * update modal layout * fix: domain cypress * minor update * update modal * fix: glossary cypress * fix: show inline errors * fix comments --------- Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes
I worked on ... because ...
Screen.Recording.2023-12-04.at.11.09.24.PM.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>