-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue-12540 and issue-13992 (apply highlights and sort in summary column as well as for tags). #14253
Conversation
glossary-term-page and applied tags in explore page
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
…ge and based on current term in glossary term page
searchResults?.hits?.hits[0]._source, | ||
searchResults?.hits?.hits[0].highlight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we extract source and highlight at top and use it accross?
Like:
const source = searchResults?.hits?.hits[0]?._source,
const highlight = searchResults?.hits?.hits[0]?.highlight
This way we are reducing "." operation each time and also a safty check to single place
|
this PR fix - #12540 and #13992 (apply highlights and sort in summary column as well as for tags).
This PR covers following things -
Before the fix
Screen.Recording.2023-12-14.at.10.13.45.AM.1.mov
Screen.Recording.2023-12-14.at.10.14.34.AM.1.mov
After the fix
Screen.Recording.2023-12-15.at.8.06.27.PM.mov
Screen.Recording.2023-12-14.at.10.24.51.AM.mov