Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue-12540 and issue-13992 (apply highlights and sort in summary column as well as for tags). #14253

Merged
merged 83 commits into from
Dec 20, 2023

Conversation

Abhishek332
Copy link
Contributor

@Abhishek332 Abhishek332 commented Dec 5, 2023

this PR fix - #12540 and #13992 (apply highlights and sort in summary column as well as for tags).

This PR covers following things -

  • sort summary columns and tags inside columns on glossary page based on current term page.
  • sort and highlight tags in right panel on glossary page based on current term page.
  • highlight and sort summary columns on global search
  • fix: entity name and entity description not get highlighted in right panel on global search until you click on SearchedCard
  • maintain the global search highlight and sort + sort and highlight summary items based on applied tag filter on explore page for every entity in explore page.
  • some redundant code removal and optimization.

Before the fix

Screen.Recording.2023-12-14.at.10.13.45.AM.1.mov
Screen.Recording.2023-12-14.at.10.14.34.AM.1.mov

After the fix

Screen.Recording.2023-12-15.at.8.06.27.PM.mov
Screen.Recording.2023-12-14.at.10.24.51.AM.mov

@github-actions github-actions bot added the UI UI specific issues label Dec 5, 2023
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@karanh37 karanh37 added the safe to test Add this label to run secure Github workflows on PRs label Dec 5, 2023
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 49%
49.76% (24913/50069) 32.49% (9778/30092) 30.95% (2825/9127)

Comment on lines 217 to 218
searchResults?.hits?.hits[0]._source,
searchResults?.hits?.hits[0].highlight
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we extract source and highlight at top and use it accross?
Like:

const source = searchResults?.hits?.hits[0]?._source,
const highlight = searchResults?.hits?.hits[0]?.highlight

This way we are reducing "." operation each time and also a safty check to single place

Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
0.0% Coverage on New Code
18.9% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants