Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets improvements part 2 #14255

Merged
merged 32 commits into from
Dec 6, 2023
Merged

Assets improvements part 2 #14255

merged 32 commits into from
Dec 6, 2023

Conversation

karanh37
Copy link
Contributor

@karanh37 karanh37 commented Dec 5, 2023

Describe your changes:

Fixes

image

image

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@karanh37 karanh37 marked this pull request as draft December 5, 2023 18:47
@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Dec 5, 2023
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 49%
49.32% (24340/49347) 31.73% (9410/29658) 30.5% (2751/9019)

@karanh37 karanh37 marked this pull request as ready for review December 6, 2023 11:53
harshach
harshach previously approved these changes Dec 6, 2023
Copy link

sonarqubecloud bot commented Dec 6, 2023

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

0.0% 0.0% Coverage
14.2% 14.2% Duplication

Copy link

sonarqubecloud bot commented Dec 6, 2023

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chirag-madlani chirag-madlani merged commit a215f03 into main Dec 6, 2023
19 checks passed
@chirag-madlani chirag-madlani deleted the assets-filters2 branch December 6, 2023 17:55
07Himank added a commit that referenced this pull request Dec 6, 2023
* fix: make filters consistent

* disable if no selection

* fix: hide notification

* fix: failed status data

* localization

* fix notification loading

* remove close icon here

* fix: cypress

* update error alert design

* fix alert styling

* fix: minor issues

* fix: redirect link of data product

* fix: minor suggestion prompt

* complete user flow

* fix: glossary cypress

* update alert view

* fix tags manipulation

* fix: domain reload fixes

Co-Authored-By: Ashish Gupta <ashish@getcollate.io>

* fix: minor loading issue on delete

* fix: add admin check for activity feed

Co-Authored-By: Ashish Gupta <ashish@getcollate.io>

* fix: minor css fixes

* fix: localisation

* fix: minor issue

* miner cypress fix

* add mlmodelservice as mlmodel parent

* fix: added null checks

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Co-authored-by: Ashish Gupta <ashish@getcollate.io>
Co-authored-by: Shailesh Parmar <shailesh.parmar.webdev@gmail.com>
Co-authored-by: 07Himank <himank07mehta@gmail.com>
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this pull request Dec 15, 2023
* fix: make filters consistent

* disable if no selection

* fix: hide notification

* fix: failed status data

* localization

* fix notification loading

* remove close icon here

* fix: cypress

* update error alert design

* fix alert styling

* fix: minor issues

* fix: redirect link of data product

* fix: minor suggestion prompt

* complete user flow

* fix: glossary cypress

* update alert view

* fix tags manipulation

* fix: domain reload fixes

Co-Authored-By: Ashish Gupta <ashish@getcollate.io>

* fix: minor loading issue on delete

* fix: add admin check for activity feed

Co-Authored-By: Ashish Gupta <ashish@getcollate.io>

* fix: minor css fixes

* fix: localisation

* fix: minor issue

* miner cypress fix

* add mlmodelservice as mlmodel parent

* fix: added null checks

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Co-authored-by: Ashish Gupta <ashish@getcollate.io>
Co-authored-by: Shailesh Parmar <shailesh.parmar.webdev@gmail.com>
Co-authored-by: 07Himank <himank07mehta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants