Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: fix ui bugs #14263

Merged
merged 1 commit into from
Dec 6, 2023
Merged

MINOR: fix ui bugs #14263

merged 1 commit into from
Dec 6, 2023

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

  • fix user api failure due to double encoding in user page activity tab
  • fix the show deleted not happening in stored procedure page
Screen.Recording.2023-12-06.at.12.41.06.PM.mov
Screen.Recording.2023-12-06.at.12.42.01.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Dec 6, 2023
@Ashish8689 Ashish8689 self-assigned this Dec 6, 2023
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Dec 6, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 49%
 49.31% (24332/49344) 31.74% (9405/29634) 30.48% (2749/9019)

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2023

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Ashish8689 Ashish8689 marked this pull request as ready for review December 6, 2023 11:30
@Ashish8689 Ashish8689 merged commit add00e5 into main Dec 6, 2023
18 of 19 checks passed
@Ashish8689 Ashish8689 deleted the bugs-fixes branch December 6, 2023 12:54
Ashish8689 added a commit that referenced this pull request Dec 6, 2023
@Ashish8689
MINOR: fix ui bugs (#14263)
19aa796 
(cherry picked from commit add00e5)
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this pull request Dec 15, 2023
@Ashish8689
MINOR: fix ui bugs (open-metadata#14263)
55c3460
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ashish8689 @chirag-madlani