Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: Docs moved out of OM folder in v1.0 & v1.1 #14267

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Conversation

ShilpaVernekar
Copy link
Contributor

Describe your changes:

Docs moved out of OM folder in v1.0 & v1.1
Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added documentation Improvements or additions to documentation safe to test Add this label to run secure Github workflows on PRs labels Dec 6, 2023
@ShilpaVernekar ShilpaVernekar enabled auto-merge (squash) December 6, 2023 11:27
@ShilpaVernekar ShilpaVernekar self-assigned this Dec 6, 2023
Copy link
Member

@aniketkatkar97 aniketkatkar97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good, Can you please verify if we have removed the /how-to-guides/openmetadata from all the places?

@ShilpaVernekar
Copy link
Contributor Author

@aniketkatkar97 replaced the links to exclude /how-to-guides/openmetadata

Comment on lines 1 to 6
# Query: /how-to-guides/openmetadata

1 result - 1 file

openmetadata-docs/content/v1.2.x/how-to-guides/user-guide-data-users/data-asset-tabs.md:
91: Check for more detailed information on the [Profiler and Data Quality Tab](/how-to-guides/data-quality-profiler/tab).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this file was added. Can you please confirm if it was intentional?

Comment on lines 1 to 17
# Query: /how-to-guides/openmetadata
# ContextLines: 1

6 results - 4 files

openmetadata-docs/content/v1.1.x/how-to-guides/user-guide-data-stewards/overview-data-assets/tabs.md:
79
80
81: Check for more detailed information on the [Profiler and Data Quality Tab](/how-to-guides/data-quality-profiler/tab).
81
82
openmetadata-docs/content/v1.1.x/how-to-guides/user-guide-data-stewards/overview-data-assets/tags.md:
36
37: Data assets can also be classified using Tiers. Learn more about [Tiers](/how-to-guides/data-governance/glossary-classification/tiers).
38
39: Among the Classification Tags, OpenMetadata has some System Classification. Learn more about the [System Tags](/how-to-guides/data-governance/glossary-classification/classification).
40
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@ShilpaVernekar
Copy link
Contributor Author

By mistake... checking

@ShilpaVernekar ShilpaVernekar merged commit b530759 into main Dec 6, 2023
11 checks passed
@ShilpaVernekar ShilpaVernekar deleted the om-docs branch December 6, 2023 12:51
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants