Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix old password match #14273

Merged
merged 10 commits into from
Dec 13, 2023
Merged

fix old password match #14273

merged 10 commits into from
Dec 13, 2023

Conversation

harsh-vador
Copy link
Contributor

@harsh-vador harsh-vador commented Dec 6, 2023 •
edited
Loading

Describe your changes:

Fixes #12584

I worked on fixing the old password validation not working while updating new password
For User side:

Screen.Recording.2023-12-07.at.3.33.09.PM.1.mov

For admin side:

Screen.Recording.2023-12-07.at.3.37.53.PM.1.1.mov

Type of change:

  • Bug fix

Checklist:

@github-actions github-actions bot added the UI UI specific issues label Dec 6, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@harsh-vador harsh-vador marked this pull request as ready for review December 7, 2023 10:14
@Sachin-chaurasiya Sachin-chaurasiya added the safe to test Add this label to run secure Github workflows on PRs label Dec 7, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 49%
 49.54% (24683/49828) 32.27% (9667/29954) 30.77% (2796/9088)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit d3b5a1a into open-metadata:main Dec 13, 2023
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this pull request Dec 15, 2023
@harsh-vador @mohityadav766
fix old password match (open-metadata#14273)
10664f2 
* fix old password match

* return bad request

* added test cases & code refactor

* comments addressed

* code refactor

---------

Co-authored-by: mohitdeuex <mohit.y@deuexsolutions.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@07Himank 07Himank 07Himank approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@harsh-vador harsh-vador

Labels
backend safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Password Change Not Validating Old Password
5 participants
@harsh-vador @chirag-madlani @07Himank @Sachin-chaurasiya @mohityadav766