Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filter deleted assets while adding #14304

Merged
merged 1 commit into from
Dec 7, 2023
Merged

fix: filter deleted assets while adding #14304

merged 1 commit into from
Dec 7, 2023

Conversation

karanh37
Copy link
Contributor

@karanh37 karanh37 commented Dec 7, 2023

Describe your changes:

Filter deleted assets while adding

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Dec 7, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 49.28% (24342/49400) 31.68% (9410/29704) 30.46% (2751/9032)

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 7, 2023

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chirag-madlani chirag-madlani merged commit d544220 into main Dec 7, 2023
13 of 14 checks passed
@chirag-madlani chirag-madlani deleted the fix-filter-deleted branch December 7, 2023 13:17
karanh37 added a commit that referenced this pull request Dec 7, 2023
@karanh37
fix: filter deleted assets while adding (#14304)
63c4b06
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this pull request Dec 15, 2023
@karanh37
fix: filter deleted assets while adding (open-metadata#14304)
387602f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karanh37 @chirag-madlani