Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Fix description and tags update from ingestion patch #14305

Merged
merged 1 commit into from
Dec 7, 2023
Merged

MINOR: Fix description and tags update from ingestion patch #14305

merged 1 commit into from
Dec 7, 2023

Conversation

OnkarVO7
Copy link
Contributor

@OnkarVO7 OnkarVO7 commented Dec 7, 2023

Describe your changes:

Fix allows descriptions and tags to be patched from ingestion for only Add operation. This ensures we do not update/replace already exiting descriptions and tags

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@OnkarVO7 OnkarVO7 requested a review from a team as a code owner December 7, 2023 12:47
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Dec 7, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 7, 2023

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

22.2% 22.2% Coverage
0.0% 0.0% Duplication

@ulixius9 ulixius9 merged commit cb94243 into main Dec 7, 2023
12 checks passed
@ulixius9 ulixius9 deleted the restrict_fields branch December 7, 2023 13:09
OnkarVO7 added a commit that referenced this pull request Dec 7, 2023
@OnkarVO7
fix desc and tags update from patch (#14305)
bd7f14a
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this pull request Dec 15, 2023
@OnkarVO7
fix desc and tags update from patch (open-metadata#14305)
53dda93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulixius9 ulixius9 ulixius9 approved these changes

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OnkarVO7 @ulixius9