Fix User Issue for reset password, and encode usernames #14314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohityadav766
added
backend
safe to test
harshach
reviewed
Dec 8, 2023
| @@ -188,7 +190,9 @@ public void sendPasswordResetLink(UriInfo uriInfo, User user, String subject, St | |||
| String passwordResetLink = | |||
| String.format( | |||
| "%s/users/password/reset?user=%s&token=%s", | |||
| getSmtpSettings().getOpenMetadataUrl(), user.getFullyQualifiedName(), mailVerificationToken); | |||
| getSmtpSettings().getOpenMetadataUrl(), | |||
| URLEncoder.encode(user.getName(), StandardCharsets.UTF_8), | |||
There was a problem hiding this comment.
getName will not add double quote to the name
harshach
approved these changes
Dec 8, 2023
|
[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!
|
|
[open-metadata-ingestion] Please retry analysis of this Pull-Request directly on SonarCloud. |
MrVinegar
pushed a commit
to MrVinegar/OpenMetadata
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>