Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#14311):Unable to add the term's name in Thai. #14315

Merged
merged 2 commits into from
Dec 8, 2023
Merged

fix(#14311):Unable to add the term's name in Thai. #14315

merged 2 commits into from
Dec 8, 2023

Conversation

Sachin-chaurasiya
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya commented Dec 8, 2023 •
edited
Loading

Describe your changes:

Fixes #14311

I updated the entityName's regex to support Unicode characters in various languages and added tests.

Tested a few scenarios

  • Team and glossary, glossary term creation
  • Assigning team as owner
  • Assigning the glossary term as a tag
  • Then filtering the asset on the explore page with owner and tags
Screen.Recording.2023-12-08.at.11.54.44.AM.mov

Type of change:

  • Bug fix

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Dec 8, 2023
@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Dec 8, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 49.28% (24342/49400) 31.68% (9410/29704) 30.46% (2751/9032)

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 8, 2023

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Sachin-chaurasiya Sachin-chaurasiya merged commit 8feb85e into main Dec 8, 2023
16 checks passed
@Sachin-chaurasiya Sachin-chaurasiya deleted the fix-14311 branch December 8, 2023 07:43
Sachin-chaurasiya added a commit that referenced this pull request Dec 8, 2023
@Sachin-chaurasiya
fix(#14311):Unable to add the term's name in Thai. (#14315)
ba06689 
* fix(#14311):Unable to add the term's name in Thai.

* add more languages unit tests

(cherry picked from commit 8feb85e)
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this pull request Dec 15, 2023
@Sachin-chaurasiya
fix(open-metadata#14311):Unable to add the term's name in Thai. (open…
038a8b8 
…-metadata#14315)

* fix(open-metadata#14311):Unable to add the term's name in Thai.

* add more languages unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach harshach approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@Sachin-chaurasiya Sachin-chaurasiya

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to add the term's name in Thai.
3 participants
@Sachin-chaurasiya @harshach @chirag-madlani