FIX #14248 - Implement test case resolution task workflow #14323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Ingestion
backend
safe to test
pmbrull
previously approved these changes
Dec 11, 2023
harshach
reviewed
Dec 11, 2023
| @@ -1426,7 +1426,10 @@ def ingest_test_case(self) -> Iterable[Either[OMetaTestCaseSample]]: | |||
| ) | |||
| create_test_case_resolution.testCaseResolutionStatusDetails = Assigned( | |||
| assignee=EntityReference( | |||
| id=user.id.__root__, type="user" | |||
| id=user.id.__root__, | |||
There was a problem hiding this comment.
assuming entity can be team or user?
also lets make sure we are validating on the backend side
There was a problem hiding this comment.
I actually just added support for user as far as task flow creation goes. I'll merge it for now to unblock UI, and add the user validation in a seperate PR.
|
[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!
|
pmbrull
approved these changes
Dec 12, 2023
MrVinegar
pushed a commit
to MrVinegar/OpenMetadata
that referenced
this pull request
Dec 15, 2023
open-metadata#14323) * feat: add test case resolution task workflow * fix: conflict with main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes #14248
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>New feature
or decision-making process is reflected in the issue.