fixes #14337: remove security gap in approval workflow #14338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
mgorsk1
changed the title
mgorsk1
requested review from
harshach,
karanh37 and
chirag-madlani
as code owners
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
pmbrull
added
the
safe to test
chirag-madlani
approved these changes
Dec 12, 2023
Jest test CoverageUI tests summary
|
|
[open-metadata-ui] Kudos, SonarCloud Quality Gate passed! |
MrVinegar
pushed a commit
to MrVinegar/OpenMetadata
that referenced
this pull request
Dec 15, 2023
…pen-metadata#14338) * 🎉 Init * 🐛 Fix variable responsible for creator * 🐛 Fix variable responsible for creator --------- Co-authored-by: at91mm <mariusz.gorski@ing.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes #14337
I worked on improving conditions for displaying approval controls because their current definitions allowed for self-approving workflows.
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>