Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Fix migration location for unity catalog #14339

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

ulixius9
Copy link
Member

@ulixius9 ulixius9 commented Dec 11, 2023

Describe your changes:

Note: The migrations on 1.2.3 dir were not shipped hence moving it to 1.3.0 dir

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@ulixius9 ulixius9 requested a review from a team December 11, 2023 15:00
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Dec 11, 2023
ayush-shah
ayush-shah previously approved these changes Dec 13, 2023
@harshach
Copy link
Collaborator

@ulixius9 why are we moving these schema changes. These must have been run by anyone who installed 1.2.3 right?

@ulixius9
Copy link
Member Author

ulixius9 commented Jan 3, 2024

Hey @harshach, we did not cherry-pick this into 1.2.3, we decided to ship this fix with 1.3.0 hence moving the migrations

@ulixius9 ulixius9 merged commit e67ffd5 into main Jan 3, 2024
14 checks passed
@ulixius9 ulixius9 deleted the move_migrations branch January 3, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants