Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #14404: table schema tab ui issues #14405

Merged
merged 9 commits into from
Dec 21, 2023
Merged

fix #14404: table schema tab ui issues #14405

merged 9 commits into from
Dec 21, 2023

Conversation

harsh-vador
Copy link
Contributor

@harsh-vador harsh-vador commented Dec 15, 2023 •
edited
Loading

Describe your changes:

Fixes #14404

  • I worked on fixing the alignment of the arrow icon in the schema table.
  • Fixed permission issue while editing description and retention period.
  • Fixed the modal scroll issue.
Screenshot 2023-12-15 at 6 15 12 PM
Screen.Recording.2023-12-21.at.11.38.43.AM.mov

Type of change:

  • Bug fix

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added the UI UI specific issues label Dec 15, 2023
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@harsh-vador harsh-vador changed the title fix #14404: Misc bug fixes fix #14404: Misc UI bug fixes Dec 15, 2023
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@harsh-vador harsh-vador marked this pull request as ready for review December 21, 2023 06:06
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@chirag-madlani chirag-madlani added the safe to test Add this label to run secure Github workflows on PRs label Dec 21, 2023
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 49%
 49.93% (24941/49952) 32.64% (9809/30053) 31.09% (2829/9099)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani changed the title fix #14404: Misc UI bug fixes fix #14404: table schema tab ui issues Dec 21, 2023
@chirag-madlani chirag-madlani merged commit b9e1360 into open-metadata:main Dec 21, 2023
18 checks passed
aniketkatkar97 pushed a commit that referenced this pull request Dec 21, 2023
@harsh-vador @aniketkatkar97
fix #14404: table schema tab ui issues (#14405)
5cabf92 
* fixed arrow name alignment issue

* fix permission issues

* fix modal scroll issue

* fixed permission issues

* minor fix

* fix failing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya left review comments

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI /UX issues - In Table's Schema, Description Model dismissal, Permission issues
3 participants
@harsh-vador @chirag-madlani @Sachin-chaurasiya