Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Cypress organise #14419

Merged
merged 50 commits into from
Jan 8, 2024
Merged

[WIP] Cypress organise #14419

merged 50 commits into from
Jan 8, 2024

Conversation

chirag-madlani
Copy link
Collaborator

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Dec 18, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2023 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 51%
 51.51% (25837/50155) 33.75% (10168/30130) 32.5% (2969/9136)

@chirag-madlani chirag-madlani added the e2e This will trigger e2e test workflows label Dec 18, 2023
@chirag-madlani chirag-madlani marked this pull request as ready for review December 18, 2023 10:11
@chirag-madlani chirag-madlani changed the title Cypress organise [WIP] Cypress organise Dec 18, 2023
@cypress Cypress
Copy link

cypress bot commented Dec 18, 2023 •
edited
Loading

11 failed tests on run #32836 ↗︎

11 655 8 0 Flakiness 0

Details:

Merge branch 'main' into cypress-organise
Project: openmetadata Commit: 1babe7e80c
Status: Failed Duration: 37:18 💡
Started: Jan 8, 2024 8:35 AM Ended: Jan 8, 2024 9:12 AM
Failed  Service/postgres.spec.js • 1 failed test • cypress-ci-mysql-oss-7444792120-1

View Output Video

Test Artifacts
Postgres Ingestion > Update table description and verify description after re-run Screenshots Video
Failed  Pages/DataQualityAndProfiler.spec.js • 4 failed tests • cypress-ci-mysql-oss-7444792120-1

View Output Video

Test Artifacts
Data Quality and Profiler should work properly > Add Profiler ingestion Screenshots Video
Data Quality and Profiler should work properly > Assign owner to test suite Screenshots Video
Data Quality and Profiler should work properly > Add test case to logical test suite Screenshots Video
Data Quality and Profiler should work properly > Remove test case from logical test suite Screenshots Video
Failed  Pages/SearchIndexDetails.spec.js • 2 failed tests • cypress-ci-mysql-oss-7444792120-1

View Output Video

Test Artifacts
Prerequisite for data steward role tests > Add data steward role to the user Screenshots Video
SearchIndexDetails page should work properly for data steward role > All permissible actions on search index details page should work properly Screenshots Video
Failed  Pages/Alerts.spec.js • 2 failed tests • cypress-ci-mysql-oss-7444792120-1

View Output Video

Test Artifacts
Alerts page should work properly > Create alert for MS Teams Screenshots Video
Alerts page should work properly > Delete created alert for msteamsAlert-ct-test-468562 Screenshots Video
Failed  Service/metabase.spec.js • 1 failed test • cypress-ci-mysql-oss-7444792120-1

View Output Video

Test Artifacts
Metabase Ingestion > Update table description and verify description after re-run Screenshots Video

The first 5 failed specs are shown, see all 6 specs in Cypress Cloud.

Review all test suite changes for PR #14419 ↗︎

@chirag-madlani chirag-madlani merged commit 98f3f07 into main Jan 8, 2024
15 of 20 checks passed
@chirag-madlani chirag-madlani deleted the cypress-organise branch January 8, 2024 09:53
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees
No one assigned
Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chirag-madlani @ShaileshParmar11