Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 14084: Removed Airflow Mssql backend connection #14420

Merged
merged 5 commits into from
Dec 20, 2023
Merged

Fix 14084: Removed Airflow Mssql backend connection #14420

merged 5 commits into from
Dec 20, 2023

Conversation

OnkarVO7
Copy link
Contributor

Describe your changes:

Fixes #14084

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@OnkarVO7 OnkarVO7 requested a review from a team as a code owner December 18, 2023 07:05
@github-actions github-actions bot added documentation Improvements or additions to documentation Ingestion backend safe to test Add this label to run secure Github workflows on PRs labels Dec 18, 2023
pmbrull
pmbrull requested changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@pmbrull pmbrull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @OnkarVO7 thanks for tackling this. Let's update the 1.3.x docs to have this highlighted on the breaking changes section

bootstrap/sql/migrations/native/1.3.0/mysql/schemaChanges.sql Show resolved Hide resolved
@OnkarVO7 OnkarVO7 requested a review from pmbrull December 19, 2023 08:45
@OnkarVO7
Copy link
Contributor Author

hi @OnkarVO7 thanks for tackling this. Let's update the 1.3.x docs to have this highlighted on the breaking changes section

@pmbrull added the breaking changes please take a look

pmbrull
pmbrull previously approved these changes Dec 19, 2023
View reviewed changes
@OnkarVO7 OnkarVO7 requested a review from pmbrull December 20, 2023 05:28
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@OnkarVO7 OnkarVO7 merged commit 7d03297 into main Dec 20, 2023
30 checks passed
@OnkarVO7 OnkarVO7 deleted the rmv_airflow_mssql_conn branch December 20, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayush-shah ayush-shah ayush-shah approved these changes

@pmbrull pmbrull Awaiting requested review from pmbrull

Assignees
No one assigned
Labels
backend documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove MSSQL backend db from Airflow Connection JSON Schema
3 participants
@OnkarVO7 @pmbrull @ayush-shah