Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LMAX Disruptor , use queue and Quartz #14422

Merged
merged 39 commits into from
Jan 8, 2024
Merged

Remove LMAX Disruptor , use queue and Quartz #14422

merged 39 commits into from
Jan 8, 2024

Conversation

mohityadav766
Copy link
Contributor

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mohityadav766 mohityadav766 added backend safe to test Add this label to run secure Github workflows on PRs labels Dec 18, 2023
@mohityadav766 mohityadav766 self-assigned this Dec 18, 2023
@mohityadav766
Merge branch 'main' into addQueue
093dfd7 
# Conflicts:
#	openmetadata-service/src/main/java/org/openmetadata/service/apps/bundles/changeEvent/email/EmailPublisher.java
#	openmetadata-service/src/main/java/org/openmetadata/service/apps/bundles/changeEvent/gchat/GChatPublisher.java
#	openmetadata-service/src/main/java/org/openmetadata/service/apps/bundles/changeEvent/generic/GenericPublisher.java
#	openmetadata-service/src/main/java/org/openmetadata/service/apps/bundles/changeEvent/msteams/MSTeamsPublisher.java
#	openmetadata-service/src/main/java/org/openmetadata/service/apps/bundles/changeEvent/slack/SlackEventPublisher.java
#	openmetadata-service/src/main/java/org/openmetadata/service/events/scheduled/ReportsHandler.java
#	openmetadata-service/src/main/java/org/openmetadata/service/events/subscription/AlertUtil.java
#	openmetadata-service/src/main/java/org/openmetadata/service/formatter/decorators/EmailMessageDecorator.java
#	openmetadata-service/src/main/java/org/openmetadata/service/formatter/decorators/GChatMessageDecorator.java
#	openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/CollectionDAO.java
#	openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EventSubscriptionRepository.java
#	openmetadata-service/src/main/java/org/openmetadata/service/resources/events/subscription/EventSubscriptionResource.java
#	openmetadata-service/src/main/java/org/openmetadata/service/util/SubscriptionUtil.java
@github-actions GitHub Actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

mohityadav766 and others added 9 commits December 27, 2023 18:22
@mohityadav766
Merge branch 'main' into addQueue
06c9b30 
# Conflicts:
#	bootstrap/sql/migrations/native/1.3.0/mysql/schemaChanges.sql
#	bootstrap/sql/migrations/native/1.3.0/postgres/schemaChanges.sql
#	openmetadata-service/src/main/java/org/openmetadata/service/apps/scheduler/AppScheduler.java
@mohityadav766
Spotless formatting
22cefe0
@mohityadav766
Review Comments
edcb5ad
@mohityadav766
Improvements
0a279bb
@mohityadav766
Improvements to add Retry and DLQ
c028984
@mohityadav766
Spotless fix
76b9076
@mohityadav766
Merge branch 'main' into addQueue
5e50d95
@mohityadav766
Update Stats
74d11ea
@mohityadav766
Fix stats
a44cfbd
@mohityadav766 mohityadav766 marked this pull request as ready for review January 2, 2024 07:06
@mohityadav766 mohityadav766 requested a review from a team as a code owner January 2, 2024 07:06
@mohityadav766 mohityadav766 requested a review from harshach January 2, 2024 07:26
harshach
harshach previously approved these changes Jan 8, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mohityadav766 mohityadav766 merged commit dad886e into main Jan 8, 2024
19 checks passed
@mohityadav766 mohityadav766 deleted the addQueue branch January 8, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach harshach left review comments

Assignees

@mohityadav766 mohityadav766

Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohityadav766 @harshach